Add retries to WaitForInstanceCompletion #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
approved these changes
Apr 18, 2025
For certain backends (like DTS), there can be a hard limit of 4 minutes for idle requests. As a WaitForInstanceCompletion sits idle while waiting, it can receive a 504. This change allows for the SDK to retry instead of returning that error to the caller. Signed-off-by: halspang <[email protected]>
halspang
force-pushed
the
halspang/retry_wait_completion
branch
from
2a49d52 to
776b10e
Compare
Signed-off-by: halspang <[email protected]>
cgillum
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain backends (like DTS), there can be a hard limit of 4 minutes for idle requests. As a WaitForInstanceCompletion sits idle while waiting, it can receive a 504. This change allows for the SDK to retry instead of returning that error to the caller.